What am I missing?
When $S_{t-1} = s, A_{t-1} = a$ is a condition as in $\mathbb{P}(X|S_{t-1} = s, A_{t-1}=a)$, it does not mean that there are any expectations or rules regarding distributions $S_{t-1}$ or $A_{t-1}$. By supplying them as a conditional in the expression, you are removing considerations of what is driving them.
Inserting $\mathbb{P}(S_{t-1} = s, A_{t-1} = a)$ into your analysis of $p(s', r|s,a)$ is making an assumption that these random variables are drawn from a distribution that you care about. You then end up constructing a circular argument, because you have implictly decided that you are drawing the distribution of $A_{t-1}$ based on the policy.
However, the update rule does not refer to how the current policy affects the initial state or action. There is no implied distribution of $S_{t-1}$ or $A_{t-1}$, they are just set arbitrarily to each state and action in the whole space as required to resolve the argmax. In the policy evaluation and policy update steps of policy iteration, the state and action being evaluated are not random variables, the notation used is partially hiding that.
In some calculations you may care about the distribution of $S_{t-1}$ and $A_{t-1}$, but it is common in RL to not make use of the distribution of these terms when they are set to fixed values in order to calculate a specific value update.